-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s3ng fix missing blob error message #3341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
wkloucek
requested review from
labkode,
ishank011,
glpatcern and
a team
as code owners
October 12, 2022 15:27
fschade
previously approved these changes
Oct 12, 2022
C0rby
previously approved these changes
Oct 12, 2022
Webdav get on folder fails now on S3: @api @skipOnOcV10.8 @skipOnOcV10.9 @skipOnOcV10.10.0
Feature: make webdav request with special urls
Background: # /drone/src/tmp/testrunner/tests/acceptance/features/apiAuthWebDav/webDavSpecialURLs.feature:4
Given user "Alice" has been created with default attributes and without skeleton files # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
And user "Alice" has uploaded file with content "some data" to "/textfile0.txt" # FeatureContext::userHasUploadedAFileWithContentTo()
And user "Alice" has uploaded file with content "some data" to "/textfile1.txt" # FeatureContext::userHasUploadedAFileWithContentTo()
And user "Alice" has created folder "/PARENT" # FeatureContext::userHasCreatedFolder()
And user "Alice" has created folder "/FOLDER" # FeatureContext::userHasCreatedFolder()
And user "Alice" has uploaded file with content "some data" to "/PARENT/parent.txt" #
Scenario: send GET requests to webDav endpoints with 2 slashes # /drone/src/tmp/testrunner/tests/acceptance/features/apiAuthWebDav/webDavSpecialURLs.feature:34
When user "Alice" requests these endpoints with "GET" using password "%regular%" about user "Alice" # OCSContext::userSendsRequestToTheseEndpointsWithOutBodyUsingPassword()
| endpoint |
| //remote.php/webdav/textfile0.txt |
| //remote.php//dav/files/%username%/textfile1.txt |
| /remote.php//dav/files/%username%/PARENT/parent.txt |
| /remote.php//webdav/PARENT |
| //remote.php/dav//files/%username%//FOLDER |
Then the HTTP status code of responses on all endpoints should be "200" # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
Expected same but found different http status codes of last requested responses.Found status codes: 200,200,200,500,500 (Exception)
@skipOnOcV10 @personalSpace
Scenario: send GET requests to webDav endpoints with 2 slashes using the spaces WebDAV API # /drone/src/tmp/testrunner/tests/acceptance/features/apiAuthWebDav/webDavSpecialURLs.feature:45
When user "Alice" requests these endpoints with "GET" using password "%regular%" about user "Alice" # OCSContext::userSendsRequestToTheseEndpointsWithOutBodyUsingPassword()
| endpoint |
| //remote.php/dav/spaces/%spaceid%/textfile0.txt |
| //remote.php//dav/spaces/%spaceid%/PARENT/parent.txt |
| /remote.php//dav/spaces/%spaceid%/PARENT |
| //remote.php/dav//spaces/%spaceid%//FOLDER |
Then the HTTP status code of responses on all endpoints should be "200" # FeatureContext::theHTTPStatusCodeOfResponsesOnAllEndpointsShouldBe()
Expected same but found different http status codes of last requested responses.Found status codes: 200,200,500,500 (Exception)
|
8ebe5c5 fixes it, don't know if it is too nice |
kobergj
approved these changes
Oct 13, 2022
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.